Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/Apple #12

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Chore/Apple #12

merged 3 commits into from
Sep 29, 2023

Conversation

borut-t
Copy link
Collaborator

@borut-t borut-t commented Sep 12, 2023

Updated response for Apple auth.

@borut-t borut-t requested a review from a team September 12, 2023 10:53
tonikocjan
tonikocjan reviewed Sep 19, 2023
View reviewed changes
Copy link

@tonikocjan tonikocjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain the reasoning behind these changes?

@borut-t
Copy link
Collaborator Author

borut-t commented Sep 19, 2023

Can you explain the reasoning behind these changes?

Email is required, expiration date is needed. There is no reason why one would continue with auth if this two parts are missing. Would you argue?

@tonikocjan
Copy link

Email is required, expiration date is needed. There is no reason why one would continue with auth if this two parts are missing. Would you argue?

👍

tonikocjan
tonikocjan approved these changes Sep 20, 2023
View reviewed changes
Copy link

@tonikocjan tonikocjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

Base automatically changed from feature/linkedin to develop September 28, 2023 19:34
@borut-t borut-t merged commit f34d118 into develop Sep 29, 2023
1 check passed
@borut-t borut-t deleted the chore/apple branch September 29, 2023 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonikocjan tonikocjan tonikocjan approved these changes

Assignees
No one assigned
Labels
rebase squash merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@borut-t @tonikocjan