Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Introduce PersonNameComponents for Google, Facebook, LinkedIn sign in #33

Merged
merged 5 commits into from
Nov 15, 2024

Conversation

EgzonArifi
Copy link
Member

No description provided.

@EgzonArifi EgzonArifi requested a review from a team November 13, 2024 10:39
Copy link
Collaborator

@borut-t borut-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🙌

Sources/Core/PersonNameComponents+Extension.swift Outdated Show resolved Hide resolved
Copy link
Member

@yllfejziu yllfejziu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👌
Just a few nitpicks below.

Sources/Core/PersonNameComponents+Extension.swift Outdated Show resolved Hide resolved
Sources/Core/PersonNameComponents+Extension.swift Outdated Show resolved Hide resolved
Sources/Core/PersonNameComponents+Extension.swift Outdated Show resolved Hide resolved
@EgzonArifi EgzonArifi merged commit bb984d3 into develop Nov 15, 2024
1 check passed
@EgzonArifi EgzonArifi deleted the person-components-response branch November 15, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants