Skip to content

Commit

Permalink
feat(power-assert-formatter): move built-in renderers to ./built-in/
Browse files Browse the repository at this point in the history
BREAKING CHANGE: built-in renderers are listed as relative-paths

If you are customizing renderers by `options.renderers`, you may have to migrate.
To migrate, change your code from the following:

```
[
    'file',
    'assertion',
    'diagram',
    'binary-expression'
]
```

To:

```
 [
    './built-in/file',
    './built-in/assertion',
    './built-in/diagram',
    './built-in/binary-expression'
 ]
```
  • Loading branch information
twada committed Sep 2, 2014
1 parent e6316e9 commit acf8510
Show file tree
Hide file tree
Showing 8 changed files with 30 additions and 30 deletions.
16 changes: 8 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,10 +123,10 @@ Constructor Function for output writer class.

```javascript
[
'./renderers/file',
'./renderers/assertion',
'./renderers/diagram',
'./renderers/binary-expression'
'./built-in/file',
'./built-in/assertion',
'./built-in/diagram',
'./built-in/binary-expression'
]
```

Expand All @@ -146,10 +146,10 @@ module.exports = function defaultOptions () {
circular: '#@Circular#',
lineSeparator: '\n',
renderers: [
'./renderers/file',
'./renderers/assertion',
'./renderers/diagram',
'./renderers/binary-expression'
'./built-in/file',
'./built-in/assertion',
'./built-in/diagram',
'./built-in/binary-expression'
]
};
};
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
8 changes: 4 additions & 4 deletions lib/create.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ var stringifier = require('stringifier'),
(function() {
// "Browserify can only analyze static requires. It is not in the scope of browserify to handle dynamic requires."
// https://github.com/substack/node-browserify/issues/377
require('./renderers/assertion');
require('./renderers/binary-expression');
require('./renderers/diagram');
require('./renderers/file');
require('./built-in/assertion');
require('./built-in/binary-expression');
require('./built-in/diagram');
require('./built-in/file');
})();

function create (options) {
Expand Down
8 changes: 4 additions & 4 deletions lib/default-options.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ module.exports = function defaultOptions () {
circular: '#@Circular#',
lineSeparator: '\n',
renderers: [
'./renderers/file',
'./renderers/assertion',
'./renderers/diagram',
'./renderers/binary-expression'
'./built-in/file',
'./built-in/assertion',
'./built-in/diagram',
'./built-in/binary-expression'
]
};
};
28 changes: 14 additions & 14 deletions test/options_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,9 @@ suite('renderers customization', function () {

rendererCustomizationTest('without file renderer', {
renderers: [
'./renderers/assertion',
'./renderers/diagram',
'./renderers/binary-expression'
'./built-in/assertion',
'./built-in/diagram',
'./built-in/binary-expression'
]
}, [
'comment ',
Expand All @@ -102,9 +102,9 @@ suite('renderers customization', function () {

rendererCustomizationTest('without assertion renderer (though it is nonsense)', {
renderers: [
'./renderers/file',
'./renderers/diagram',
'./renderers/binary-expression'
'./built-in/file',
'./built-in/diagram',
'./built-in/binary-expression'
]
}, [
'comment # /path/to/some_test.js:1',
Expand All @@ -124,9 +124,9 @@ suite('renderers customization', function () {

rendererCustomizationTest('without diagram renderer', {
renderers: [
'./renderers/file',
'./renderers/assertion',
'./renderers/binary-expression'
'./built-in/file',
'./built-in/assertion',
'./built-in/binary-expression'
]
}, [
'comment # /path/to/some_test.js:1',
Expand All @@ -144,9 +144,9 @@ suite('renderers customization', function () {

rendererCustomizationTest('without binary-expression renderer', {
renderers: [
'./renderers/file',
'./renderers/assertion',
'./renderers/diagram'
'./built-in/file',
'./built-in/assertion',
'./built-in/diagram'
]
}, [
'comment # /path/to/some_test.js:1',
Expand All @@ -173,9 +173,9 @@ suite('renderers customization', function () {
}
rendererCustomizationTest('without binary-expression renderer', {
renderers: [
'./renderers/file',
'./built-in/file',
CustomRenderer,
'./renderers/binary-expression'
'./built-in/binary-expression'
]
}, [
'comment # /path/to/some_test.js:1',
Expand Down

0 comments on commit acf8510

Please sign in to comment.