Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for providing custom functions in Expressions. #142

Merged
merged 1 commit into from
Jan 27, 2019
Merged

Added support for providing custom functions in Expressions. #142

merged 1 commit into from
Jan 27, 2019

Conversation

stlhrt
Copy link
Contributor

@stlhrt stlhrt commented Jan 23, 2019

Resolved #133

@stlhrt stlhrt force-pushed the Add-support-for-providing-custom-functions-in-Expressions branch 3 times, most recently from c0c0f81 to c186869 Compare January 23, 2019 22:07
mariuszkumor
mariuszkumor reviewed Jan 24, 2019
View reviewed changes
...ows/dmn/engine/evaluator/expression/provider/LiteralExpressionEvaluationProviderFactory.java Show resolved Hide resolved
...a/org/powerflows/dmn/engine/evaluator/expression/provider/binding/InstanceMethodBinding.java Outdated Show resolved Hide resolved
...ava/org/powerflows/dmn/engine/evaluator/expression/provider/binding/StaticMethodBinding.java Outdated Show resolved Hide resolved
...flows/dmn/engine/evaluator/expression/provider/GroovyExpressionEvaluationProviderSpec.groovy Outdated Show resolved Hide resolved
...flows/dmn/engine/evaluator/expression/provider/GroovyExpressionEvaluationProviderSpec.groovy Outdated Show resolved Hide resolved
...flows/dmn/engine/evaluator/expression/provider/GroovyExpressionEvaluationProviderSpec.groovy Outdated Show resolved Hide resolved
...flows/dmn/engine/evaluator/expression/provider/GroovyExpressionEvaluationProviderSpec.groovy Outdated Show resolved Hide resolved
...s/dmn/engine/evaluator/expression/provider/JavascriptExpressionEvaluationProviderSpec.groovy Outdated Show resolved Hide resolved
...s/dmn/engine/evaluator/expression/provider/JavascriptExpressionEvaluationProviderSpec.groovy Outdated Show resolved Hide resolved
src/main/java/org/powerflows/dmn/engine/configuration/DefaultDecisionEngineConfiguration.java Show resolved Hide resolved
mariuszkumor
mariuszkumor requested changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@mariuszkumor mariuszkumor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes needed. The pull request look really nice.

@stlhrt stlhrt force-pushed the Add-support-for-providing-custom-functions-in-Expressions branch from c186869 to 0073b93 Compare January 26, 2019 22:46
@stlhrt stlhrt force-pushed the Add-support-for-providing-custom-functions-in-Expressions branch from 0073b93 to 45c4818 Compare January 26, 2019 23:26
@mariuszkumor mariuszkumor added the enhancement New feature or request label Jan 27, 2019
@stlhrt stlhrt merged commit 60a8dcc into develop Jan 27, 2019
@stlhrt stlhrt deleted the Add-support-for-providing-custom-functions-in-Expressions branch January 27, 2019 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariuszkumor mariuszkumor mariuszkumor approved these changes

Assignees

@stlhrt stlhrt

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stlhrt @mariuszkumor