Skip to content

WIP: Add sync implementation from core extension #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

simolus3
Copy link
Contributor

This adds an option to use a new sync implementation from the core extension instead of the JavaScript implementation. The core implementation is marked as experimental, and we default to the old implementation.

The implementation changes are surprisingly compact:

  1. In AbstractRemote.ts, this introduces "raw" variant of the sync stream methods. Those don't parse sync lines, instead returning them as strings (HTTP streaming) or buffers (RSocket).
  2. In AbstractStreamingSyncImplementation.ts, copy the existing sync implementation into a method and add a new one for the core sync implementation.

See also:

Copy link

changeset-bot bot commented May 13, 2025

⚠️ No Changeset found

Latest commit: 9aea8ec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant