fix: Revert Web Vite Config Breaking changes #776
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Some changes introduced in #753
unintentionally caused breakages for consumers using Vite’s development build process.
That refactor externalised
event-iteratorandbufferfor non-Node.js builds of@powersync/common. As a result, Vite dev servers can fail with errors such as:and
While consumers can work around this by updating their Vite configs, requiring manual configuration changes is potentially a breaking change. For example:
optimizeDeps: { // Don't optimize these packages as they contain web workers and WASM files. // https://github.com/vitejs/vite/issues/11672#issuecomment-1415820673 exclude: ["@journeyapps/wa-sqlite", "@powersync/web"], include: [ + "@powersync/web > event-iterator", ], }, plugins: [wasm(), topLevelAwait()], worker: { format: "es", plugins: () => [wasm(), topLevelAwait()], }, +resolve: { + alias: { + buffer: "buffer", + }, +},This PR reverts the externalisation to prevent consumers from running into these issues.
This problem didn’t surface within the monorepo because of how our package structure behaves during local development. To prevent regressions going forward, the isolated tests have been expanded to include Vite unit tests for the
example-vitedemo. These tests run against a real Vite dev server and will fail with the same errors if the configuration becomes invalid again.