Avoid persisting SqliteInputValues #342
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#331 introduced
SqliteInputValueand theCustomSqliteValueclass to represent values that may have to be synced differently depending on compatibility options. The original idea was that each sync stream and SQL bucket or event descriptor would apply their compatibility options when mapping the row, so thatCustomSqliteValues are temporary instances living between the replicator and sync rules.That approach is flawed in two ways:
To fix this, this moves the responsibility of applying the compatibility context to the batch implementation (which has all the necessary data because the compatibility context is known via the sync rules instance). That also means that we'll store mapped representations instead of the original values.