Reduce warnings for sync after uploads #128
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the following sequence of events:
$local.target_op
is at 1<<62.1
.upload_completed
notification to the Rust client. That tries applying the previous checkpoint, which fails because it doesn't have a write checkpoint. A "Could not apply pending checkpoint even after completed upload" warning message is logged.This is actually fairly common, and a completely harmless sequence of events that both the service and the client handle correctly. It's just the warning message that stands out here. So, this PR removes that message.
This also adds tests for:
Closes powersync-ja/powersync-kotlin#243.