-
Notifications
You must be signed in to change notification settings - Fork 7
feat: add watchOS support (tentative) #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for getting started on this!
I've started looking into support for this for our Kotlin SDK here: https://github.com/powersync-ja/powersync-kotlin/tree/watchOS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this against the Kotlin and Swift SDKs, so this looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simolus3 I'm happy with the changes, but there are still some build failures
Thanks, should be fixed now 👍 |
Notes from Simon: I've ensured that all our tests for the Kotlin and Swift SDKs pass when they're built against this framework on watchOS simulators. I don't have an actual watchOS device to test this on, but since the link mode is the same on those platforms I think it should work. My stance is that this is good enough to merge, but we'll have to do more testing on actual devices before even announcing this as experimental.
To test this, see:
Not a watchOS expert, so carefully review and guidance required.