v0.5.1: Close write connection after read connections; Fix watch with query parameters #12
+134
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkistner
changed the title
wessels2
approved these changes
Aug 3, 2023
Fix typo Co-authored-by: wessels2 <95405275+wessels2@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close write connection after read connections
Fixes #11.
Closing the write connection usually cleans up the journal files (-shm and -wal files).
It can only do that if there are no other open connections, so we close the read-only connections first.
Fix watch with query parameters
When parameters were passed to
watch, theEXPLAINpart that to get affected tables failed. This fixes it.