Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for volume swells. #17

Closed
Canaanabolaanan opened this issue Jul 23, 2014 · 1 comment
Closed

Add support for volume swells. #17

Canaanabolaanan opened this issue Jul 23, 2014 · 1 comment
Labels
C-editing C-midi C-ptb1.7 enhancement medium priority
Milestone
Alpha 13

Comments

@Canaanabolaanan
Copy link

No editing. Imports don't display.
-Display swell start/stop volumes (can be hidden during playback).

Test file -
https://onedrive.live.com/redir?resid=BF1A7BA5AAA1B4E4!150&authkey=!AAOADj63_NhYSuo&ithint=file%2cptb
cameronwhite added a commit that referenced this issue Jun 23, 2020
@cameronwhite
Split out the VolumeLevel enum from the Dynamic class.
1d85fae 
This will also be used for volume swells, and it makes more sense to have as a standalone enum (and an enum class for proper namespacing)

#17
cameronwhite added a commit that referenced this issue Jun 24, 2020
@cameronwhite
Initial work on implementing volume swells.
17219c4 
This adds an optional volume swell to the Position object, similar to how it was implemented in v1.7

#17
cameronwhite added a commit that referenced this issue Jun 24, 2020
@cameronwhite
Import volume swells from v1.7 files.
a03f6ea 
#17
cameronwhite added a commit that referenced this issue Jun 24, 2020
@cameronwhite
Support rendering of volume swells.
ed3453d 
This was mostly resurrecting old code that predated the .pt2 file format, but with some tweaks to fix issues where the swells could intersect with adjacent symbols.

#17
cameronwhite added a commit that referenced this issue Jun 24, 2020
@cameronwhite
Resurrect the Add / Remove Volume Swell undo actions.
495b9e4 
#17
cameronwhite added a commit that referenced this issue Jun 24, 2020
@cameronwhite
Fix incorrect drawing of swells for the final position in a staff.
39ce738 
#17
cameronwhite added a commit that referenced this issue Jun 24, 2020
@cameronwhite
Add support for editing volume swells.
6b32d81 
- Removed old dead code from powertabeditor.cpp
- Improved the old volume swell dialog's layout to match the dynamics dialog

#17
cameronwhite added a commit that referenced this issue Jun 24, 2020
@cameronwhite
Add MIDI support for volume swells.
1d114cc 
#17
@cameronwhite
Copy link
Member

This has now been implemented!

@cameronwhite cameronwhite added this to the Alpha 13 milestone Jun 24, 2020
@cameronwhite cameronwhite mentioned this issue Jan 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-editing C-midi C-ptb1.7 enhancement medium priority
Projects
None yet
Milestone
Alpha 13
Development

No branches or pull requests
2 participants
@cameronwhite @Canaanabolaanan