Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rit./accel. #18

Closed
Canaanabolaanan opened this issue Jul 24, 2014 · 1 comment
Closed

Add support for rit./accel. #18

Canaanabolaanan opened this issue Jul 24, 2014 · 1 comment

Comments

@Canaanabolaanan
Copy link

Rit./Accel. measures operate at a constant pace for the duration of measures between the current and ending tempo markers. The pace is fixed regardless of the tempos before or after them, or whether they are higher/lower than the rit/accel constant tempo pace.

If the rit/accel markers occur within a measure, they'll play at the aforementioned constant tempo, but the measure itself occupies the space of the measure as set by the tempo marker before it.

If the rit/accel markers are placed on the barline instead, there is no extra empty space at the end of the measure.

The Rit. tempo is somewhere above 300BPM (the limit for PTE1.7). The Accel. tempo is at about 250.

In 1.7, a rit. and an accel. perform identically. The only thing that truly matters is the starting/ending tempo markers.
For instance, a
(t=120 -accel- t=180) will play identically to a
(t=120 -rit- t=180.)

Test files:
https://onedrive.live.com/redir?resid=BF1A7BA5AAA1B4E4!157&authkey=!AOxEDsTIUlHlVk4&ithint=folder%2c

@cameronwhite
Copy link
Member

We can currently create alterations of pace and import them from v1.7 files, so we just need to add MIDI support.

@cameronwhite cameronwhite added this to the Alpha 3 milestone Aug 18, 2014
@cameronwhite cameronwhite modified the milestones: Alpha 4, Alpha 3 Aug 30, 2014
@cameronwhite cameronwhite modified the milestone: Alpha 4 Sep 20, 2014
@cameronwhite cameronwhite added this to the Alpha 9 milestone Jun 28, 2015
@cameronwhite cameronwhite modified the milestones: Alpha 10, Alpha 9 Nov 19, 2015
@cameronwhite cameronwhite modified the milestone: Alpha 10 Dec 23, 2016
cameronwhite added a commit that referenced this issue Jun 26, 2020
This is basically working, but just needs some further refactoring to clean it up.

Also fixed a bug I noticed where the duration for whole rests was incorrectly computed (very small). I don't think this had any effect on MIDI playback though since the metronome ticks are always played for the full bar.

#18
@cameronwhite cameronwhite added this to the Alpha 13 milestone Jun 26, 2020
cameronwhite added a commit that referenced this issue Jun 26, 2020
This avoids potential confusion and errors, which I encountered for c8175d3.

#18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants