Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shifting tab numbers up/down #20

Closed
cameronwhite opened this issue Jul 24, 2014 · 0 comments
Closed

Shifting tab numbers up/down #20

cameronwhite opened this issue Jul 24, 2014 · 0 comments
Labels
C-editing enhancement medium priority
Milestone
Alpha 13

Comments

@cameronwhite
Copy link
Member

Ideally this should also work if you have multiple selected notes.
@cameronwhite cameronwhite mentioned this issue Sep 1, 2014
Closed
cameronwhite added a commit that referenced this issue Jun 22, 2020
@cameronwhite
Initial work on resurrecting the shift string command.
df80803 
This doesn't do much at the moment, and is mostly getting code compiling again.

- Renamed the Shift Forward / Backward commands to Insert / Remove Space, to hopefully reduce confusion with string shifting (and potential future commands for shifting notes up / down by a semitone)
- Name this command as Shift String Up/Down

#20
cameronwhite added a commit that referenced this issue Jun 22, 2020
@cameronwhite
Implement more robust string shifting.
000e47f 
- Fail and revert the changes if one of the selected notes can't be shifted.
- Check that the new string and fret numbers are valid.
- Use the active tuning to determine the new fret number.
- Clear note properties from the adjacent notes (such as hammerons). However, these properties are preserved between a set of shifted notes.

#20
cameronwhite added a commit that referenced this issue Jun 22, 2020
@cameronwhite
Add several more tests for string shifting.
a7de48a 
Fixed several edge cases, such as shifting notes on adjacent strings in the correct order.

#20
@cameronwhite cameronwhite added this to the Alpha 13 milestone Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-editing enhancement medium priority
Projects
None yet
Milestone
Alpha 13
Development

No branches or pull requests
1 participant
@cameronwhite