-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a dark theme for the score #286
Comments
hello, I have checked #284, and I think #286 is more of a generic feature for all OSs, not just just an issue for OSX like the previous bug, as mentioned in the label. Is that true or did I misunderstand something? |
This would be great to have someone work on! My original thinking was to follow the application's color palette (https://doc.qt.io/qt-5/qguiapplication.html#palette) which https://doc.qt.io/qt-5/qpalette.html recommends using, since that would follow whatever the default color scheme is from the user's environment. The score uses some additional color shades, so it might need to use something like I don't know for sure if this is the best approach, but I think it's at least a good start to identify and fix all the hardcoded colours in the score rendering code. The |
A related bug I noticed is that time signatures and key signatures are not visible in the OSX dark mode, because they are drawn with white text (probably inheriting the default theme) over a white background, instead of switching to dark text. |
@cameronwhite |
The music notes are all drawn from a font, so I think it's just a matter of choosing the right text colour when they're drawn (hopefully!) |
…er (tabs) are now dependent on system default colors/theme using Qpalette * Changes tested on Ubuntu using Adwaita and Adwaita-dark themes powertab#286
…alette of the system * Printing with default palette needs to be implemented powertab#286
…the default colors * minor refactoring * scoreArea background color changed to be Light instead of Backroung color (in light theme, Background is light grey) powertab#286
Related to #284 (which was resolved by always using a white background), it would be nice to support a dark theme for the score view.
The text was updated successfully, but these errors were encountered: