New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View filter dialog improvements #295

Closed

3 tasks done

cameronwhite opened this issue Jun 7, 2020 · 0 comments

Labels

C-ui enhancement

Milestone

Member

cameronwhite commented Jun 7, 2020 •

edited

Loading

A crash occurs if an invalid regex is provided (e.g. *foo). This should be propagated into a non-fatal warning or error
Using the arrow keys to move through the list of filters does not properly update the selection - only clicking on an entry works
It would be nice to provide a preview of which players this matches against.

The text was updated successfully, but these errors were encountered:

cameronwhite added enhancement C-ui labels

cameronwhite added a commit that referenced this issue


          Enable changing the selected filter using the arrow keys

32222fd

#295

cameronwhite added a commit that referenced this issue


          Highlight invalid filter patterns instead of crashing.

c44ca37

#295

cameronwhite closed this as completed in

f6478ba

cameronwhite added this to the Alpha 13 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment