Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a view filter to omit the drums when importing Guitar Pro files. #298

Open
cameronwhite opened this issue Jun 11, 2020 · 2 comments
Open

Comments

@cameronwhite
Copy link
Member

Related to #290, the imported drum track is currently not very useful, so it would be good to be able to easily hide it.
Or perhaps we should just skip importing it until drum scores are implemented?

@psyomn
Copy link
Contributor

psyomn commented Jun 11, 2020

Would it make sense to import and hide, so that the user in the future, would not have to re-import files? I don't know what kind of file format nightmare this might contribute to maintainability though.

@cameronwhite
Copy link
Member Author

I think I'd lean towards skipping - right now a Score has no notion of drums, so the result is just whatever guitar properties the importer happens to find (and it wouldn't suddenly start working for old imported files if drums support was added). For .gpx files I think all the notes show up as the 0 fret, so a lot of data is definitely being missed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants