Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Score Polisher command #78

Closed
ghost opened this issue Aug 18, 2014 · 3 comments
Closed

Add a Score Polisher command #78

ghost opened this issue Aug 18, 2014 · 3 comments
Labels
C-editing enhancement medium priority
Milestone
Alpha 3

Comments

@ghost
Copy link

ghost commented Aug 18, 2014

Any plans to add "shift forward" (spacebar in 1.7) or justify features (j in 1.7). Would be really useful. Thanks!
@cameronwhite
Copy link
Member

Shift forward is already there (under the Position menu) - it uses Insert instead since the spacebar now controls MIDI playback, but you can change that if you want using File/Customize Shortcuts.

Adding a score polisher is definitely something that I want to add before the final 2.0 release, since we need it for importing Guitar Pro files (#26)

@cameronwhite cameronwhite changed the title shift forward and justify Add a Score Polisher command Aug 19, 2014
@cameronwhite cameronwhite mentioned this issue Aug 19, 2014
Closed
cameronwhite added a commit that referenced this issue Aug 20, 2014
@cameronwhite
Initial work on a score polisher.
e05d49d 
- Note durations can now be handled as fractions instead of
floating-point numbers.
- The score polishing is currently not undoable.
- There are some issues with adjusting irregular groups, and the score
polisher still needs much more testing in general.

Bug: #78
cameronwhite added a commit that referenced this issue Aug 21, 2014
@cameronwhite
Adjust the locations of irregular groups when formatting the score.
4667a7c 
Bug: #78
@cameronwhite cameronwhite added this to the Alpha 3 milestone Aug 21, 2014
@Canaanabolaanan
Copy link

Super trivial, but I recommend "j" remain the default key for this, most likely implying "justify," as in text alignment.

Edit - Actually, I guess "j" was used for an individual system justify, rather than the whole piece. Any interest in adding in that feature? Could be j for a system justify, and J for score justify.

@cameronwhite
Copy link
Member

Yeah, a per-system justify would be easy to add. Probably should go under a separate bug report though

cameronwhite added a commit that referenced this issue Aug 31, 2014
@cameronwhite
Add a command to polish a single system.
7408375 
Bug: #78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-editing enhancement medium priority
Projects
None yet
Milestone
Alpha 3
Development

No branches or pull requests
2 participants
@cameronwhite @Canaanabolaanan