Keep constant power factor only if P0 != 0

Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
powsybl · Feb 9, 2024 · 02d785e · 02d785e
1 parent d6c8cfe
commit 02d785e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/.../iidm-modification/src/main/java/com/powsybl/iidm/modification/scalable/LoadScalable.java b/.../iidm-modification/src/main/java/com/powsybl/iidm/modification/scalable/LoadScalable.java
@@ -150,7 +150,7 @@ public double scale(Network n, double asked, ScalingParameters parameters) {
         LOGGER.info("Change active power setpoint of {} from {} to {} ",
                 l.getId(), oldP0, l.getP0());
 
-        if (parameters.isConstantPowerFactor()) {
+        if (parameters.isConstantPowerFactor() && oldP0 !=0) {
             l.setQ0(l.getP0() * oldQ0 / oldP0);
             LOGGER.info("Change reactive power setpoint of {} from {} to {} ",
                     l.getId(), oldQ0, l.getQ0());

diff --git a/...m-modification/src/test/java/com/powsybl/iidm/modification/scalable/LoadScalableTest.java b/...m-modification/src/test/java/com/powsybl/iidm/modification/scalable/LoadScalableTest.java
@@ -185,6 +185,13 @@ void testConstantPowerFactor() {
         ls1.scale(network, 20, parameters);
         assertEquals(60, load.getP0(), 1e-3);
         assertEquals(7.5, load.getQ0(), 1e-3);
+
+        ls1.reset(network);
+        assertEquals(0.0, load.getP0(), 1e-3);
+        assertEquals(7.5, load.getQ0(), 1e-3);
+        ls1.scale(network, -20, parameters);
+        assertEquals(20.0, load.getP0(), 1e-3);
+        assertEquals(7.5, load.getQ0(), 1e-3);
     }
 
     @Test