Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data store implementation #1327
Data store implementation #1327
Changes from 14 commits
0cbefb9
4807466
483741c
7ffaea1
31e07be
3e4043c
f868992
327e144
8aed2a8
5809716
b4113e9
aad07dc
f59bb6f
c1f62f9
78c6741
b13c5df
142d8ab
83451a0
1ced3fb
abf1cd2
7ae1555
4bbb06a
7613a58
478fc8a
d9535d5
60e30c6
df56cf5
64856f8
334e55c
b91fe8d
e781808
6184a5c
884f8e0
8d1c9de
2463a3b
597de37
aa6471e
71f029f
11388c9
6212993
2c47bd0
428a52d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As in gzip implementation, I think we should throw an IOException if the entryName does not match the registered one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add javadoc to explain the contract of this interface.