Refactoring security-analysis-api : Remove WithLog suffixed methods #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
sylvlecl
reviewed
Mar 29, 2021
...nalysis/security-analysis-api/src/main/java/com/powsybl/security/SecurityAnalysisResult.java
Outdated
Show resolved
Hide resolved
...sis/security-analysis-api/src/main/java/com/powsybl/security/tools/SecurityAnalysisTool.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
|
Kudos, SonarCloud Quality Gate passed! |
miovd
approved these changes
Apr 29, 2021
sylvlecl
approved these changes
May 3, 2021
miovd
pushed a commit
that referenced
this pull request
May 4, 2021
…1667) * Remove SecurityAnalysisResultWithLog class * Replace WithLog methods with bollean usage * Add SecurityAnalysisReport composed by SecurityAnalysisResult & LogBytes Signed-off-by: Thomas ADAM <tadam@silicom.fr>
miovd
pushed a commit
that referenced
this pull request
May 4, 2021
…1667) * Remove SecurityAnalysisResultWithLog class * Replace WithLog methods with bollean usage * Add SecurityAnalysisReport composed by SecurityAnalysisResult & LogBytes Signed-off-by: Thomas ADAM <tadam@silicom.fr>
miovd
pushed a commit
that referenced
this pull request
May 25, 2021
…1667) * Remove SecurityAnalysisResultWithLog class * Replace WithLog methods with bollean usage * Add SecurityAnalysisReport composed by SecurityAnalysisResult & LogBytes Signed-off-by: Thomas ADAM <tadam@silicom.fr>
EtienneLt
pushed a commit
that referenced
this pull request
May 27, 2021
…1667) * Remove SecurityAnalysisResultWithLog class * Replace WithLog methods with bollean usage * Add SecurityAnalysisReport composed by SecurityAnalysisResult & LogBytes Signed-off-by: Thomas ADAM <tadam@silicom.fr>
miovd
pushed a commit
that referenced
this pull request
Jun 14, 2021
…1667) * Remove SecurityAnalysisResultWithLog class * Replace WithLog methods with bollean usage * Add SecurityAnalysisReport composed by SecurityAnalysisResult & LogBytes Signed-off-by: Thomas ADAM <tadam@silicom.fr>
miovd
added a commit
that referenced
this pull request
Jun 14, 2021
* Remove deprecated code (#1579) * Use ServiceLoader to create SecurityAnalysis (#1585) * Add SecurityAnalysisProvider * Add FIXME to rename later and fix comments issues * Remove runWithLog method in SecurityAnalysisProvider * Replace SecurityAnalysis factory uses by loaded SecurityAnalysisProvider (#1618) * Refactoring security-analysis-api : SecurityAnalysisImpl (issue 1604) (#1648) * Refactoring security-analysis-api : Remove WithLog suffixed methods (#1667) * Remove SecurityAnalysisResultWithLog class * Replace WithLog methods with bollean usage * Add SecurityAnalysisReport composed by SecurityAnalysisResult & LogBytes Signed-off-by: Thomas ADAM <tadam@silicom.fr> * After rebasing: bump to 4.2.0-SNAPSHOT version + do not use "default" word in automatic module name (forbidden) * Add default impl of API AS in distribution core * Bump to 4.3.0-SNAPSHOT Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com> * Monitor security analysis (#1737) * On demand results for specific equipments Signed-off-by: Etienne Lesot <etienne.lesot@rte-france.com> * Corrections following reviewer's comments: - Rename SecurityAnalysisResult.getPreContingencyLimitViolationsResult - Use only pre/post contingency in javadoc - Put methods in StateMonitorJson in StateMonitor - Clear before addAll in setMonitors * Corrections following reviewer's comments: - PreContingencyResult constructor requires Collections, not Maps - Correct SecurityAnalysisResult deserializer and test files - Optimize monitor merging in StateMonitorIndex - Add ID-based getters in PreContingencyResult - Delete redundant methods in SecurityAnalysisResult - If a monitored ID does not exist, ignore it - Add tests * Rebasing from master and resolving conflicts Co-authored-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com> Co-authored-by: EtienneLt <32468651+EtienneLt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restfix #1602
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Refactoring of security-analysis-api module
What is the current behavior? (You can also link to an open issue here)
Results are represented by two différents classes SecurityAnalysisResult & SecurityAnalysisResultWithLog.
SecurityAnalysisProvider provides two différents methods run & runWithLog
What is the new behavior (if this is a feature change)?
SecurityAnalysisResultWithLogis removed andlogBytesfield is forwarded intoSecurityAnalysisResult.SecurityAnalysis,SecurityAnalysisProvider&SecurityAnalysisExecutiondo not contains WithLog suffixed methods.A new field
boolean withLogswas added intoSecurityAnalysisExecutionInputclass representing"log-file"SecurityAnalysisTooloption.This new field in
SecurityAnalysisExecutionimplementations, to know if log files is requested.Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)