Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hypotheses to create a voltage level on a line and to attach a line to another line #1945

Merged
merged 8 commits into from
Feb 16, 2022

Conversation

miovd
Copy link
Contributor

@miovd miovd commented Jan 19, 2022

Signed-off-by: VEDELAGO MIORA miora.ralambotiana@rte-france.com

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
No

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Moving code from powsybl/powsybl-network-hypothesis and correcting code

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

@miovd miovd marked this pull request as ready for review January 20, 2022 13:56
@miovd miovd requested review from annetill and geofjamg January 20, 2022 13:57
@miovd miovd force-pushed the topology_utils branch 2 times, most recently from 56a0c29 to 6dcfbff Compare January 21, 2022 10:57
@miovd miovd force-pushed the topology_utils branch 3 times, most recently from 703dd69 to 6beb624 Compare February 14, 2022 09:03
…ne to another line

Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>

Add javadoc

Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>

Typo

Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>

Typo

Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
@miovd miovd changed the title Add hypotheses to create a voltage level on a line and to attach a line to another line [WIP] Add hypotheses to create a voltage level on a line and to attach a line to another line Feb 14, 2022
Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
@miovd miovd changed the title [WIP] Add hypotheses to create a voltage level on a line and to attach a line to another line Add hypotheses to create a voltage level on a line and to attach a line to another line Feb 14, 2022
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Copy link
Member

@geofjamg geofjamg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only potential NPE in case of IDs not found in the network to fix.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

82.3% 82.3% Coverage
0.0% 0.0% Duplication

@miovd miovd merged commit 6427c27 into main Feb 16, 2022
@miovd miovd deleted the topology_utils branch February 16, 2022 08:46
colinepiloquet pushed a commit that referenced this pull request Mar 8, 2022
…ne to another line (#1945)

Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants