Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topological nodes set can not be null #1957

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Conversation

marcosmc
Copy link
Contributor

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature

What is the current behavior? (You can also link to an open issue here)
When obtaining the list of topological nodes of a bus, it is verified that it is not null.

What is the new behavior (if this is a feature change)?
Currently this list cannot be null, so the check is unnecessary.

Signed-off-by: AIA_NT\demiguelm <demiguelm@aia.es>
@marcosmc marcosmc requested review from miovd and zamarrenolm January 28, 2022 10:44
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.5% 95.5% Coverage
0.0% 0.0% Duplication

Copy link
Member

@zamarrenolm zamarrenolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge this PR, but after reviewing it I think we need to improve the export at least in two ways:

  • When doing a full export from a pure IIDM Network, the extension CgmesIidmMapping should also be created and filled. It contains mapping data between CGMES and IIDM that should be reused if the same Network is exported again (base voltages, for example). Other mapping information is already been stored as aliases and properties, so it is also reused if re-exporting.
  • The mapping between Network buses and TNs should be "updated". Currently, it is either read from the extension or created from scratch. If a user imports a Network from CGMES, then creates new buses on the Network, the mapping would became invalid (would miss mappings for the new buses).

@miovd
Copy link
Contributor

miovd commented Jan 28, 2022

I think we can merge this PR, but after reviewing it I think we need to improve the export at least in two ways:

* When doing a full export from a pure IIDM Network, the extension CgmesIidmMapping should also be created and filled. It contains mapping data between CGMES and IIDM that should be reused if the same Network is exported again (base voltages, for example). Other mapping information is already been stored as aliases and properties, so it is also reused if re-exporting.

* The mapping between Network buses and TNs should be "updated". Currently, it is either read from the extension or created from scratch. If a user imports a Network from CGMES, then creates new buses on the Network, the mapping would became invalid (would miss mappings for the new buses).

I agree with you. I was already working on some improvements including making CgmesIidmMapping topology invalid when the network topology is modified.

@miovd miovd merged commit 925e233 into main Jan 28, 2022
@miovd miovd deleted the remove-topological-nodes-check branch January 28, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants