-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CGMES-IIDM mapping #1959
Conversation
...c/main/java/com/powsybl/cgmes/conversion/elements/AbstractConductingEquipmentConversion.java
Show resolved
Hide resolved
… create CGMES mapping in bus-branch + create mapping for future CGMES export when exporting for first time Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
…evel Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
3ef2ad7
to
5fd95eb
Compare
…opology + add update method Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
…ix sonar issue Signed-off-by: Luma <zamarrenolm@aia.es>
… clarify unit tests Signed-off-by: Luma <zamarrenolm@aia.es>
Updated the changes with the following: Topological Node mappings are added also for b/b models (removed the Sometimes we may be importing only EQ data, then we may not have a CGMES Topological Node to add to the mapping. We take this into account and avoid putting nulls in the mapping (check and log debug in When we are testing EQ export of Networks that come from CGMES source, we are re-importing only using the exported EQ file (+boundaries). When we re-import we do not need to create the IIDM-CGMES mapping: we are in fact dropping all IIDM-CGMES mapping to compare expected and actual Networks. Change in For switches, TP export was missing the association of terminals with the corresponding Topological Nodes. New method |
Kudos, SonarCloud Quality Gate passed! |
Please check if the PR fulfills these requirements (please use
'[x]'
to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'
and skip the restNo
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Improvements
What is the current behavior? (You can also link to an open issue here)
Some inconsistencies in CGMES mapping
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
No