Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CGMES-IIDM mapping #1959

Merged
merged 11 commits into from
Mar 10, 2022
Merged

Improve CGMES-IIDM mapping #1959

merged 11 commits into from
Mar 10, 2022

Conversation

miovd
Copy link
Contributor

@miovd miovd commented Jan 28, 2022

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
No

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Improvements

What is the current behavior? (You can also link to an open issue here)
Some inconsistencies in CGMES mapping

What is the new behavior (if this is a feature change)?

  • Add listeners to invalidate CGMES-IIDM topology mapping when topology is modified
  • Can create CGMES-IIDM mapping during CGMES import of a Bus-Branch network
  • When first export, create CGMES-IIDM mapping on network for redundancy

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
No

@miovd miovd requested review from marcosmc and zamarrenolm January 28, 2022 13:51
@miovd miovd changed the title Improve CGMES-IIDM mapping [WIP] Improve CGMES-IIDM mapping Jan 28, 2022
@miovd miovd changed the title [WIP] Improve CGMES-IIDM mapping Improve CGMES-IIDM mapping Jan 31, 2022
@miovd miovd changed the title Improve CGMES-IIDM mapping [WIP] Improve CGMES-IIDM mapping Feb 7, 2022
miovd added 5 commits February 8, 2022 09:24
… create CGMES mapping in bus-branch + create mapping for future CGMES export when exporting for first time

Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
…evel

Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
@miovd miovd force-pushed the improve_cgmes_mapping branch from 3ef2ad7 to 5fd95eb Compare February 8, 2022 08:25
…opology + add update method

Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
@miovd miovd changed the title [WIP] Improve CGMES-IIDM mapping Improve CGMES-IIDM mapping Mar 3, 2022
@miovd miovd requested a review from marcosmc March 7, 2022 11:46
@zamarrenolm
Copy link
Member

Updated the changes with the following:

Topological Node mappings are added also for b/b models (removed the context.nodeBreaker condition at the start of Conversion::convert when building the CGMES-IIDM mappings).

Sometimes we may be importing only EQ data, then we may not have a CGMES Topological Node to add to the mapping. We take this into account and avoid putting nulls in the mapping (check and log debug in AbstractConductingEquipmentConversion::addMappingForTopologicalNode).

When we are testing EQ export of Networks that come from CGMES source, we are re-importing only using the exported EQ file (+boundaries). When we re-import we do not need to create the IIDM-CGMES mapping: we are in fact dropping all IIDM-CGMES mapping to compare expected and actual Networks. Change in EquipmentExportTest. Also small refactoring in this module to clarify the operations and verifications being made.

For switches, TP export was missing the association of terminals with the corresponding Topological Nodes. New method TopologyExport::writeSwitchesTerminals and minor changes to clarify code.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

86.5% 86.5% Coverage
0.0% 0.0% Duplication

@miovd miovd merged commit 575c262 into main Mar 10, 2022
@miovd miovd deleted the improve_cgmes_mapping branch March 10, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants