Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional clarifications on power flow inputs (SSH) and state values (SV) #1963

Merged
merged 9 commits into from
Feb 8, 2022

Conversation

marqueslanauja
Copy link
Contributor

@marqueslanauja marqueslanauja commented Feb 2, 2022

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

The current configuration parameter profileUsedForInitialFlowsValues has been changed to readShuntSectionsTapPositionsFromSVIfPresent. By default is set to false.
Now this parameter only decides the source (SSH or SV) for shunt sections and tap positions.

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

marqueslanauja and others added 6 commits January 18, 2022 11:18
@zamarrenolm zamarrenolm marked this pull request as ready for review February 3, 2022 15:36
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja marqueslanauja changed the title Cgmes clarify ssh sv values Additional clarifications on power flow inputs (SSH) and state values (SV) Feb 3, 2022
zamarrenolm and others added 2 commits February 7, 2022 10:31
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

72.0% 72.0% Coverage
0.0% 0.0% Duplication

@miovd
Copy link
Contributor

miovd commented Feb 7, 2022

@zamarrenolm If it is okay for you, we can merge this PR

@zamarrenolm
Copy link
Member

@zamarrenolm If it is okay for you, we can merge this PR

just approved, it is ok for me

@miovd miovd merged commit 82e85fa into main Feb 8, 2022
@miovd miovd deleted the cgmes-clarify-SSH-SV-values branch February 8, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants