-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional clarifications on power flow inputs (SSH) and state values (SV) #1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
…onsFromSVIfPresent Signed-off-by: José Antonio Marqués <marquesja@aia.es>
zamarrenolm
requested changes
Feb 3, 2022
cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/CgmesImport.java
Outdated
Show resolved
Hide resolved
marqueslanauja
changed the title
Cgmes clarify ssh sv values
Additional clarifications on power flow inputs (SSH) and state values (SV)
Feb 3, 2022
miovd
reviewed
Feb 4, 2022
cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/CgmesImport.java
Outdated
Show resolved
Hide resolved
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
SonarCloud Quality Gate failed. |
miovd
approved these changes
Feb 7, 2022
@zamarrenolm If it is okay for you, we can merge this PR |
zamarrenolm
approved these changes
Feb 7, 2022
just approved, it is ok for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'
to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'
and skip the restWhat kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
The current configuration parameter
profileUsedForInitialFlowsValues
has been changed toreadShuntSectionsTapPositionsFromSVIfPresent
. By default is set to false.Now this parameter only decides the source (SSH or SV) for shunt sections and tap positions.
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)