Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameters to limit post contingency limit violations result #1975

Merged
merged 11 commits into from
Feb 18, 2022
Merged

Add parameters to limit post contingency limit violations result #1975

merged 11 commits into from
Feb 18, 2022

Conversation

annetill
Copy link
Member

@annetill annetill commented Feb 15, 2022 •
edited
Loading

Signed-off-by: Anne Tilloy anne.tilloy@rte-france.com

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest

No.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

The PR introduces three new parameters in security analysis parameters:

  • A threshold to filter the flow violations after contingencies if they are increasing less than a given factor (without unit).
  • A delta to filter the low voltage violations after contingencies if the decrease is less than a given value (in kV).
  • A delta to filter the high voltage violations after contingencies if the increase is less than a given value (in kV).

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

@annetill
Add parameters to limit post contingency limit violations result.
0b13c33 
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
geofjamg
geofjamg requested changes Feb 15, 2022
View reviewed changes
Copy link
Member

@geofjamg geofjamg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to handle loading default values from platform config

annetill and others added 2 commits February 15, 2022 12:08
@annetill
Change parameter names and add two new parameters.
37c5061 
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
@EtienneLt
add json de/serializer and more tests
7993189 
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
sylvlecl
sylvlecl requested changes Feb 15, 2022
View reviewed changes
security-analysis/security-analysis-api/src/test/resources/SecurityAnalysisParameters.json Outdated Show resolved Hide resolved
...sis/security-analysis-api/src/main/java/com/powsybl/security/SecurityAnalysisParameters.java Show resolved Hide resolved
...sis/security-analysis-api/src/main/java/com/powsybl/security/SecurityAnalysisParameters.java Outdated Show resolved Hide resolved
...sis/security-analysis-api/src/main/java/com/powsybl/security/SecurityAnalysisParameters.java Outdated Show resolved Hide resolved
...sis/security-analysis-api/src/main/java/com/powsybl/security/SecurityAnalysisParameters.java Outdated Show resolved Hide resolved
security-analysis/security-analysis-api/src/test/resources/SecurityAnalysisParameters.json Outdated Show resolved Hide resolved
...ysis-api/src/main/java/com/powsybl/security/json/SecurityAnalysisParametersDeserializer.java Outdated Show resolved Hide resolved
...alysis-api/src/main/java/com/powsybl/security/json/SecurityAnalysisParametersSerializer.java Outdated Show resolved Hide resolved
...security-analysis-api/src/test/java/com/powsybl/security/SecurityAnalysisParametersTest.java Outdated Show resolved Hide resolved
security-analysis/security-analysis-api/src/test/resources/SecurityAnalysisParameters.json Outdated Show resolved Hide resolved
annetill and others added 4 commits February 15, 2022 18:00
@annetill
Apply some review comments.
220a13a 
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
@annetill
Apply the review comments I understand.
341883b 
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
@geofjamg
Merge branch 'main' into increase-security-analysis-parameters
deaf628
@geofjamg
Few fixes
9c292be 
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
@EtienneLt EtienneLt force-pushed the increase-security-analysis-parameters branch 2 times, most recently from 9526089 to ebaeb33 Compare February 17, 2022 12:25
sylvlecl
sylvlecl requested changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@sylvlecl sylvlecl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last minor changes

...sis/security-analysis-api/src/main/java/com/powsybl/security/SecurityAnalysisParameters.java Outdated Show resolved Hide resolved
...alysis-api/src/main/java/com/powsybl/security/json/SecurityAnalysisParametersSerializer.java Outdated Show resolved Hide resolved
...alysis-api/src/main/java/com/powsybl/security/json/SecurityAnalysisParametersSerializer.java Outdated Show resolved Hide resolved
@EtienneLt EtienneLt force-pushed the increase-security-analysis-parameters branch from ca0e311 to 2f27dd3 Compare February 17, 2022 15:02
@EtienneLt
few corrections
55a0372 
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
@EtienneLt EtienneLt force-pushed the increase-security-analysis-parameters branch from 2f27dd3 to 55a0372 Compare February 17, 2022 15:17
@sylvlecl sylvlecl self-requested a review February 17, 2022 16:05
@geofjamg
Add method chaining
988eeb0 
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

85.7% 85.7% Coverage
0.0% 0.0% Duplication

@annetill annetill merged commit 9a4fbc6 into main Feb 18, 2022
@annetill annetill deleted the increase-security-analysis-parameters branch February 18, 2022 12:10
miovd pushed a commit that referenced this pull request Feb 23, 2022
@annetill @miovd
Add parameters to limit post contingency limit violations result (#1975)
9abf75b 
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
colinepiloquet pushed a commit that referenced this pull request Mar 8, 2022
@annetill @colinepiloquet
Add parameters to limit post contingency limit violations result (#1975)
49771a4 
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EtienneLt EtienneLt EtienneLt left review comments

@sylvlecl sylvlecl sylvlecl approved these changes

@geofjamg geofjamg geofjamg approved these changes

Assignees
No one assigned
Labels
PR: next-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@annetill @geofjamg @sylvlecl @EtienneLt