Fix removing the "last" variant of a network for tap changers #1979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: EDWARDS Philippe <edwardsphi@gm0winl197.bureau.si.interne>
geofjamg
reviewed
Feb 17, 2022
|
indeed, I'll look for that line of code in all the files to make sure there are no other bugs |
Signed-off-by: EDWARDS Philippe <edwardsphi@gm0winl197.bureau.si.interne>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
… into fix_tap_changer_variant_removal
I would say it is ok now. I searched in the delayed validation PR for other |
geofjamg
approved these changes
Feb 17, 2022
geofjamg
added
bug
December release
PR: next-release
and removed
December release
labels
|
Kudos, SonarCloud Quality Gate passed! |
miovd
pushed a commit
that referenced
this pull request
Feb 23, 2022
* Fix removing the "last" variant of a network for tap changers * fix same issue with ShuntCompensatorImpl sectionCount Signed-off-by: EDWARDS Philippe <edwardsphi@gm0winl197.bureau.si.interne> Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
colinepiloquet
pushed a commit
that referenced
this pull request
Mar 8, 2022
* Fix removing the "last" variant of a network for tap changers * fix same issue with ShuntCompensatorImpl sectionCount Signed-off-by: EDWARDS Philippe <edwardsphi@gm0winl197.bureau.si.interne> Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: EDWARDS Philippe edwardsphi@gm0winl197.bureau.si.interne
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restNo
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
When deleting the network variant with the highest index, the tap changers will lose the wrong number of values for the tap position attribute.
What is the new behavior (if this is a feature change)?
It now loses the expected number of values.
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)