Geographical and ControlArea persistence #1983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AIA_NT\demiguelm <demiguelm@aia.es>
Signed-off-by: AIA_NT\demiguelm <demiguelm@aia.es>
Signed-off-by: AIA_NT\demiguelm <demiguelm@aia.es>
marcosmc
requested review from
miovd and
zamarrenolm
and removed request for
miovd
Signed-off-by: Luma <zamarrenolm@aia.es>
zamarrenolm
approved these changes
Mar 22, 2022
miovd
reviewed
Mar 22, 2022
Comment on lines
+453
to
+470
| private void addIidmMappingsControlArea(Network network) { | ||
| CgmesControlAreas cgmesControlAreas = network.getExtension(CgmesControlAreas.class); | ||
| if (cgmesControlAreas == null) { | ||
| network.newExtension(CgmesControlAreasAdder.class).add(); | ||
| cgmesControlAreas = network.getExtension(CgmesControlAreas.class); | ||
| String cgmesControlAreaId = CgmesExportUtil.getUniqueId(); | ||
| cgmesControlAreas.newCgmesControlArea() | ||
| .setId(cgmesControlAreaId) | ||
| .setName("Network") | ||
| .setEnergyIdentificationCodeEic("Network--1") | ||
| .add(); | ||
| CgmesControlArea cgmesControlArea = cgmesControlAreas.getCgmesControlArea(cgmesControlAreaId); | ||
| for (DanglingLine danglingLine : network.getDanglingLines()) { | ||
| cgmesControlArea.add(danglingLine.getTerminal()); | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Could you explain why you're adding Control areas here? I don't think it is needed...
There was a problem hiding this comment.
The CGMES export was creating a "default" control area if none was defined in the input files, or the Network came from IIDM.
Instead of only writing it in the export module, we also keep it in the CGMES-IIDM mappings, as we are doing for the rest of information produced. The export module will write what is found in the CGMES-IIDM mapping data.
There was a problem hiding this comment.
Ok, thank you for your answer
miovd
approved these changes
Mar 24, 2022
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
The original Id of the Geographical and Subgeographical Regions are not preserved in the export to CGMES.
What is the new behavior (if this is a feature change)?
Keep the Id of the Geographical and Subgeographical Regions if it exists, or create a new Id to use for all network exports.