Add new overload for loadNetwork and improve code in Importers #1986
Conversation
miovd
changed the title
Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
miovd
force-pushed
the
add_improve_importers
branch
from
3ce7647 to
70c9529
Compare
| public void importData() { | ||
| Network network = Importers.importData(loader, TEST_FORMAT, null, null, computationManager, importConfigMock); | ||
| public void importData() throws IOException { | ||
| Network network = Importers.loadNetwork((ReadOnlyDataSource) null); |
There was a problem hiding this comment.
Probably has nothing to do with this PR, but what is the purpose of this test?????
Why are we allowing a null data source and then check that with a mock importer, we have succeed to import a network?
There was a problem hiding this comment.
Maybe it would worth a fix but could be done in another PR, as you wish
There was a problem hiding this comment.
I think it was to test if the importer was found in the LOADER and not the importer itself (it tests the mechanisms to find an importer).
There was a problem hiding this comment.
I think it was to test if the importer was found in the LOADER and not the importer itself (it tests the mechanisms to find an importer).
In any case null datasource should throw an exception even in such a test
There was a problem hiding this comment.
I'm writing an issue about it
|
Kudos, SonarCloud Quality Gate passed! |
Signed-off-by: VEDELAGO MIORA miora.ralambotiana@rte-france.com
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restNo
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature : Add some overload of
Importers.loadNetworkwhich allowsReadOnlyDataSourceas parameterDoes this PR introduce a breaking change or deprecate an API? If yes, check the following:
No