-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
loadflow parameters extensions managed by Loadflow provider #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EtienneLt
force-pushed
the
parameters-in-lf-provider
branch
from
February 24, 2022 14:32
e31aa69
to
bc1eb25
Compare
3 tasks
EtienneLt
changed the title
extension loadflow parameters added with Loadflow provider
loadflow parameters extensions managed by Loadflow provider
Feb 28, 2022
EtienneLt
force-pushed
the
parameters-in-lf-provider
branch
from
March 1, 2022 13:49
bc1eb25
to
55594b6
Compare
geofjamg
requested changes
Mar 2, 2022
loadflow/loadflow-api/src/main/java/com/powsybl/loadflow/LoadFlowProvider.java
Outdated
Show resolved
Hide resolved
loadflow/loadflow-api/src/main/java/com/powsybl/loadflow/LoadFlowProvider.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
EtienneLt
force-pushed
the
parameters-in-lf-provider
branch
from
March 3, 2022 10:02
55594b6
to
d216acc
Compare
geofjamg
approved these changes
Mar 15, 2022
sylvlecl
requested changes
Mar 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final naming + implementation details
loadflow/loadflow-api/src/main/java/com/powsybl/loadflow/LoadFlowParameters.java
Outdated
Show resolved
Hide resolved
loadflow/loadflow-api/src/main/java/com/powsybl/loadflow/LoadFlowProvider.java
Outdated
Show resolved
Hide resolved
loadflow/loadflow-api/src/main/java/com/powsybl/loadflow/LoadFlowProvider.java
Outdated
Show resolved
Hide resolved
loadflow/loadflow-api/src/main/java/com/powsybl/loadflow/json/JsonLoadFlowParameters.java
Outdated
Show resolved
Hide resolved
loadflow/loadflow-api/src/main/java/com/powsybl/loadflow/LoadFlowParameters.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>
Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Kudos, SonarCloud Quality Gate passed! |
Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>
sylvlecl
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Etienne LESOT etienne.lesot@rte-france.com
Please check if the PR fulfills these requirements (please use
'[x]'
to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'
and skip the restfix #1984