Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor support for severity in functional logs #1995

Merged
merged 6 commits into from
Mar 7, 2022

Conversation

zamarrenolm
Copy link
Member

@zamarrenolm zamarrenolm commented Mar 1, 2022

Signed-off-by: Luma zamarrenolm@aia.es

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
Fix #1950

Signed-off-by: Luma <zamarrenolm@aia.es>
@zamarrenolm zamarrenolm requested review from miovd and flo-dup March 1, 2022 15:37
Signed-off-by: Luma <zamarrenolm@aia.es>
Signed-off-by: Luma <zamarrenolm@aia.es>
Signed-off-by: Luma <zamarrenolm@aia.es>
Copy link
Contributor

@flo-dup flo-dup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just wondering if we shouldn't go further after this PR, by adding ReportBuilder.withSeverity(String) and deprecating ReportBuilder.withSeverity(TypedValue). What do you think?

@zamarrenolm
Copy link
Member Author

I'm just wondering if we shouldn't go further after this PR, by adding ReportBuilder.withSeverity(String) and deprecating ReportBuilder.withSeverity(TypedValue). What do you think?

I prefer that severity is built using a typed value that we can ensure has the proper "type" (a SEVERITY) instead of any string the user puts.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.5% 95.5% Coverage
0.0% 0.0% Duplication

@miovd miovd merged commit a595487 into main Mar 7, 2022
@miovd miovd deleted the report_severity_typed_values branch March 7, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for severity in functional logs
3 participants