Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set consistent P & Q on both sides of the lines #2014

Merged
merged 2 commits into from
Mar 22, 2022
Merged

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented Mar 15, 2022

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ?
No

What kind of change does this PR introduce?
Bug fix

What is the current behavior?
P & Q values non consistent (same value on both sides of the line)

What is the new behavior (if this is a feature change)?
P & Q values at each side of the lines are opposite

Does this PR introduce a breaking change or deprecate an API?
No

flo-dup and others added 2 commits March 15, 2022 10:38
@flo-dup flo-dup requested a review from annetill March 21, 2022 12:27
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@annetill annetill merged commit a8259e0 into main Mar 22, 2022
@annetill annetill deleted the eurostag_fix_pq branch March 22, 2022 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants