Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept that scalable can be empty + throw exception if a percentage is undefined in ProportionalScalable #2026

Merged
merged 2 commits into from
Mar 22, 2022

Conversation

miovd
Copy link
Contributor

@miovd miovd commented Mar 21, 2022

Signed-off-by: VEDELAGO MIORA miora.ralambotiana@rte-france.com

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
No but linked to powsybl/powsybl-entsoe#22

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fixes:

  • accepting empty scalable (linked to GLSK case)
  • throwing an error when percentage is NaN

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Yes

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

…s undefined in ProportionalScalable

Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

50.0% 50.0% Coverage
0.0% 0.0% Duplication

@annetill annetill merged commit 632c9b9 into main Mar 22, 2022
@annetill annetill deleted the accept_empty_scalable branch March 22, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants