-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor PowerFactory object reference #2041
Conversation
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only two minor things,
The method traverseAndReference
of the DataObject
class is not used after your refactor and can be deleted.
Maybe, to be clearer, change DataAttributeType.OBJECT
to DataAttributeType.OBJECTREF
and DataAttributeType.OBJECT_VECTOR
to DataAttributeType.OBJECTREF_VECTOR
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
I removed traverseAndReference. |
Kudos, SonarCloud Quality Gate passed! |
Signed-off-by: Geoffroy Jamgotchian geoffroy.jamgotchian@gmail.com
Please check if the PR fulfills these requirements (please use
'[x]'
to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'
and skip the restNo
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Design fix
What is the current behavior? (You can also link to an open issue here)
When reading from DGS file, object reference are modeled by an INTEGER64 attribute, which is wrong. There are INTEGER64 attributes that are not object references and there is a dedicated type (see PF C++ API) for that.
What is the new behavior (if this is a feature change)?
A new
DataObjectRef
has been added to handled non resolved object references and a global data object index has also been added to allow reference resolving (and also avoid recomputing object index in converter).Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)