Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: CGMES region and subregion are set from country and geotag (not randomly) #2048

Merged
merged 2 commits into from
Mar 30, 2022

Conversation

miovd
Copy link
Contributor

@miovd miovd commented Mar 29, 2022

Signed-off-by: VEDELAGO MIORA miora.ralambotiana@rte-france.com

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
No

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix: CGMES regions and subregions are set from countries and geographical tags if they exist in CgmesExportContext and not uniquely generated for each substation

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
No

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

…ndomly)

Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
@miovd miovd added the CGMES label Mar 29, 2022
@miovd miovd changed the title Bug fix: region and subregion are set from country and geotag (not randomly) Bug fix: CGMES region and subregion are set from country and geotag (not randomly) Mar 29, 2022
Copy link
Member

@colinepiloquet colinepiloquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on my use case and it's working! Thanks

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

93.9% 93.9% Coverage
0.0% 0.0% Duplication

@miovd miovd merged commit e1de32b into main Mar 30, 2022
@miovd miovd deleted the fix_cgmes_geo_mapping branch March 30, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants