Powerfactory lines: shunt admittance calculation. #2055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
marqueslanauja
changed the title
zamarrenolm
reviewed
Apr 4, 2022
| return new TwoNodeRefs(nodeRefs.get(0), nodeRefs.get(1)); | ||
| } | ||
|
|
||
| static class TwoNodeRefs { |
There was a problem hiding this comment.
I think we do not need to create this class. We could keep the method checkNodes(obj, int connections) returning directly a List<NodeRef>. For 3-winding transformers we would need to extend it anyway
zamarrenolm
reviewed
Apr 4, 2022
|
|
||
| static Optional<LineModel> createFromTypLne(DataObject elmLne) { | ||
| Optional<DataObject> typLne = elmLne.getObjectAttributeValue(TYP_ID).resolve(); | ||
| if (typLne.isPresent()) { |
There was a problem hiding this comment.
use of isPresent, Optional.of and empty can be simplified using map
Signed-off-by: Luma <zamarrenolm@aia.es>
zamarrenolm
approved these changes
Apr 4, 2022
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
geofjamg
approved these changes
Apr 4, 2022
|
Kudos, SonarCloud Quality Gate passed! |
miovd
pushed a commit
that referenced
this pull request
Apr 6, 2022
Signed-off-by: José Antonio Marqués <marquesja@aia.es> Signed-off-by: Luma <zamarrenolm@aia.es>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restWhat kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
An exception is thrown if
TypLneparameters are not defined.tlineparameter of TypLne is managed as conductance.Only the
blineparameter is accepted as susceptance.0.00001factor is used to convert micro siemens to siemens.What is the new behavior (if this is a feature change)?
TypLneparameters are managed as optional.Different alternatives are accepted to define conductance:
glineparameter, conductance defined in terms of the insulation factorg = tline * bDifferent alternatives are accepted to define susceptance:
blineparameter,clineparameter.0.000001factor is used to convert micro siemens to siemens.Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)