PowerFactory: GeneratorConverter #2061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
geofjamg
reviewed
Apr 6, 2022
| @@ -21,6 +21,8 @@ | |||
| */ | |||
| public abstract class AbstractConverter { | |||
|
|
|||
| static final String TYP_ID = "typ_id"; | |||
There was a problem hiding this comment.
Maybe we can more all attribute names in a dedicated utility class DataAttributeNames?
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
Signed-off-by: Luma <zamarrenolm@aia.es>
|
Kudos, SonarCloud Quality Gate passed! |
zamarrenolm
approved these changes
Apr 8, 2022
geofjamg
approved these changes
Apr 8, 2022
miovd
pushed a commit
that referenced
this pull request
Apr 11, 2022
Signed-off-by: José Antonio Marqués <marquesja@aia.es> Signed-off-by: Luma <zamarrenolm@aia.es>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: José Antonio Marqués marquesja@aia.es
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restWhat kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
Only
iv_modeis considered to definevoltageRegulatorOnQ_minandQ_maxare used to convert per unit reactive limits to Mvar reactive limitsWhat is the new behavior (if this is a feature change)?
Use
iv_modeandav_modeto definevoltageRegulatorOnUse targetP as default active power limit.
Use
sgnto convert per unit reactive limits to Mvar reactive limitsInterpret
Q_minandQ_maxas Mvar reactive limitsDoes this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)