Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All CGMES models after version 3 can be considered node/breaker #2067

Merged
merged 3 commits into from
Apr 11, 2022

Conversation

zamarrenolm
Copy link
Member

Signed-off-by: Luma zamarrenolm@aia.es

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
CGMES 3 EQ profile enforces use of ConnectivityNodes even for bus/branch models, so it is safe to assume we can process any CGMES 3 or later using ConnectivityNodes instead of relying on TopologicalNodes. If model is bus/branch, internal connections between the equipment and the busbar sections associated to connectivity nodes will be created.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

@zamarrenolm zamarrenolm requested a review from miovd April 8, 2022 16:25
@zamarrenolm zamarrenolm marked this pull request as ready for review April 8, 2022 16:37
@@ -45,6 +45,7 @@ private CgmesNamespace() {
private static final String CIM_16_SV_PROFILE = "http://entsoe.eu/CIM/StateVariables/4/1";
private static final String CIM_16_SSH_PROFILE = "http://entsoe.eu/CIM/SteadyStateHypothesis/1/1";

private static final String CGMES_EQ_3_OR_GREATER_PREFIX = "http://iec.ch/TC57/ns/CIM/CoreEquipment-EU/";
Copy link
Contributor

@miovd miovd Apr 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this used? Does it exist? (Just for information)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, to check if an EQ file is version 3 or later (when checking if all loaded EQs are CGMES 3), CgmesModelTripleStore::allEqCgmes3OrGreater

miovd added 2 commits April 11, 2022 11:39
Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

91.3% 91.3% Coverage
0.0% 0.0% Duplication

@miovd miovd merged commit 38f0817 into main Apr 11, 2022
@miovd miovd deleted the cgmes3_is_node_breaker_always_true branch April 11, 2022 12:38
miovd added a commit that referenced this pull request Apr 11, 2022
Signed-off-by: Luma <zamarrenolm@aia.es>
Co-authored-by: miovd <miora.ralambotiana@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants