XmlInputFactory: manually clear the inputstream to allow gc #2128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonenst
changed the title
jonenst
force-pushed
the
fixgcxmlimporter
branch
2 times, most recently
from
d71660a to
2c8ee24
Compare
jonenst
changed the title
jonenst
changed the title
…allow gc. Make the code more uniform. A reference to the last inputstream is kept by the factory, and we keep the factory in a static reference. Signed-off-by: HARPER Jon <jon.harper87@gmail.com>
miovd
approved these changes
May 23, 2022
geofjamg
approved these changes
May 30, 2022
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: HARPER Jon jon.harper87@gmail.com
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restNO
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
When using a unoptimzed datasource that uses byteArrayInputStreams with the whole xml string in memory, the whole string is kept in memory twice: once for the exists method (the one that is only checking if the xml has a xiidm:network), and one for the import.
What is the new behavior (if this is a feature change)?
whole string Only kept once
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
NO