Introduce ScalingParameters for Scalable #2461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annetill
reviewed
Feb 6, 2023
...ification/src/main/java/com/powsybl/iidm/modification/scalable/AbstractCompoundScalable.java
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
geofjamg
requested changes
Mar 13, 2023
| @@ -109,7 +109,7 @@ public void filterInjections(Network n, List<Injection> injections, List<String> | |||
| * If scalingConvention is GENERATOR, the load active power decreases for positive "asked" and increases inversely | |||
| */ | |||
| @Override | |||
| public double scale(Network n, double asked, Scalable.ScalingConvention scalingConvention) { | |||
| public double scale(Network n, double asked, Scalable.ScalingConvention scalingConvention, boolean reconnect) { | |||
There was a problem hiding this comment.
We really should consider grouping all theses parameters in a ScalingContext object.
colinepiloquet
force-pushed
the
fix_connect_scalable_optional
branch
from
8012cdc to
8e4c410
Compare
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
This reverts commit 8e4c410. Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
colinepiloquet
force-pushed
the
fix_connect_scalable_optional
branch
from
defa7e5 to
bda3d70
Compare
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
colinepiloquet
commented
Mar 13, 2023
| */ | ||
| public static ScalingContext getDefault() { | ||
| return new ScalingContext(Scalable.ScalingConvention.GENERATOR, false, false); | ||
| } |
There was a problem hiding this comment.
I am not sure if it is the right design but it seems useful to have a default context
geofjamg
reviewed
Mar 13, 2023
| @@ -109,9 +109,9 @@ public void filterInjections(Network n, List<Injection> injections, List<String> | |||
| * If scalingConvention is GENERATOR, the load active power decreases for positive "asked" and increases inversely | |||
| */ | |||
| @Override | |||
| public double scale(Network n, double asked, Scalable.ScalingConvention scalingConvention) { | |||
| public double scale(Network n, double asked, ScalingContext context) { | |||
There was a problem hiding this comment.
If we just add read only data in ScalingContext, it is not really a context. It is more a ScalingParameter
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
annetill
changed the title
geofjamg
approved these changes
Mar 14, 2023
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
miovd
approved these changes
Mar 15, 2023
|
Kudos, SonarCloud Quality Gate passed! |
flo-dup
approved these changes
Mar 15, 2023
| @@ -134,43 +134,10 @@ enum ScalingConvention { | |||
| * @param asked value asked to adjust the scalable active power | |||
There was a problem hiding this comment.
You should add param annotation in the javadoc for the new parameter
phiedw
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Coline PILOQUET coline.piloquet@rte-france.com
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restNo
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix: adds a boolean saying whether the terminal should be reconnected in case of scaling on a disconnected element.
What is the current behavior? (You can also link to an open issue here)
The terminal is always reconnected.