CGMES import: active power control extension is optional #2462
Conversation
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
| .add(); | ||
| if (context.config().createActivePowerControlExtension()) { | ||
| g.newExtension(ActivePowerControlAdder.class) | ||
| .withParticipate(normalPF != 0.0) |
There was a problem hiding this comment.
we should probably change this to .withParticipate(true) always
CGMES does not have an equivalent for this participate attribute
then load flow implementations can use distribution proportional to Pmax, to targetP, to remaining margin, independently of this participate flag for iIDMs created from CGMES
There was a problem hiding this comment.
Yes, I was thinking about that too... One of our test is failing because only one generator has a participating to true.
There was a problem hiding this comment.
Formal documentation about CGMES participation factor (normalPF) only says it is used for distributed slack: Generating unit economic participation factor. The sum of the participation factors across generating units does not have to sum to one. It is used for representing distributed slack participation factor. The attribute shall be a positive value or zero.
It seems correct to set the flag participating to false when normalPF is zero, but if that introduces noise, I agree on setting it always to true, and let the Load Flow engines decide later if the unit is effectively used for distributed slack looking the participationFactor value.
There was a problem hiding this comment.
Thanks @zamarrenolm for these clarifications and your approval :-)
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
| @@ -298,6 +304,7 @@ private void copyStream(ReadOnlyDataSource from, DataSource to, String fromName, | |||
| public static final String SOURCE_FOR_IIDM_ID = "iidm.import.cgmes.source-for-iidm-id"; | |||
| public static final String STORE_CGMES_MODEL_AS_NETWORK_EXTENSION = "iidm.import.cgmes.store-cgmes-model-as-network-extension"; | |||
| public static final String STORE_CGMES_CONVERSION_CONTEXT_AS_NETWORK_EXTENSION = "iidm.import.cgmes.store-cgmes-conversion-context-as-network-extension"; | |||
| public static final String CREATE_ACTIVE_POWER_CONTROL_EXTENSION = "iidm.import.cgmes.create-active-power-extension"; | |||
There was a problem hiding this comment.
iidm.import.cgmes.create-active-power-control-extension
| @@ -810,6 +810,15 @@ public Config setStoreCgmesConversionContextAsNetworkExtension(boolean storeCgme | |||
| return this; | |||
| } | |||
|
|
|||
| public boolean createActivePowerControlExtension() { | |||
| return createActivePowerExtension; | |||
There was a problem hiding this comment.
createActivePowerControlExtension
| return createActivePowerExtension; | ||
| } | ||
|
|
||
| public Config setCreateActivePowerExtension(boolean createActivePowerExtension) { |
There was a problem hiding this comment.
setCreateActivePowerControlExtension
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Luma <zamarrenolm@aia.es>
|
Kudos, SonarCloud Quality Gate passed! |
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com> Co-authored-by: Luma <zamarrenolm@aia.es>
Signed-off-by: Anne Tilloy anne.tilloy@rte-france.com
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restWhat kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)