Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlaftormConfig: config folder not created if non existing #2492

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented Mar 8, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ?
Yes, fixes #2482

Other information:
Note that InMemoryPlatformConfig still creates a config dir. Indeed this PlatformConfig is (only) used in unit tests, and in some of them files are copied into the config dir.

flo-dup added 2 commits March 8, 2023 15:56
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup flo-dup requested a review from geofjamg March 8, 2023 15:01
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@flo-dup flo-dup requested a review from miovd March 8, 2023 15:46
@flo-dup flo-dup merged commit dac761d into main Mar 8, 2023
@flo-dup flo-dup deleted the doNotCreateConfigDir branch March 8, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic creation of $HOME/.itools ?
2 participants