Matpower importer: Support lines with different nominal voltage at both ends #2493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
|
We have verified that OLF (1.0.1) solves correctly all Matpower samples taking into account the base voltages and performing the de-normalization implemented in this Pull Request. As expected, the solutions obtained are exactly the same ones that are obtained if base voltages are completely ignored in the IIDM model. |
zamarrenolm
approved these changes
Mar 10, 2023
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
annetill
approved these changes
Mar 14, 2023
zamarrenolm
approved these changes
Mar 14, 2023
|
Kudos, SonarCloud Quality Gate passed! |
annetill
deleted the
matpower_linesWithDifferentNominalVoltageAtBothEnds
branch
miovd
pushed a commit
that referenced
this pull request
Mar 30, 2023
…th ends (#2493) Signed-off-by: José Antonio Marqués <marquesja@aia.es>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restWhat kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
Conversion of electric characteristics for lines with different nominal voltage at both ends is incorrect. De-normalization from per-unit quantities to engineering units must take into account both nominal voltages.
What is the new behavior (if this is a feature change)?
De-normalization from per-unit quantities to engineering units for lines with different nominal voltage at both ends has been fixed. We have decided to keep them as transmission lines instead of transformers. If modeled as transformers, end nodes should have to be grouped in the same substation.
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)