Add add method to the adders API #2502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
And leave raw parameter for parameter class added Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
miovd
reviewed
Mar 14, 2023
iidm/iidm-api/src/main/java/com/powsybl/iidm/network/HvdcConverterStationAdder.java
Show resolved
Hide resolved
iidm/iidm-api/src/main/java/com/powsybl/iidm/network/InjectionAdder.java
Show resolved
Hide resolved
| import com.powsybl.iidm.network.IdentifiableAdder; | ||
| import com.powsybl.iidm.network.util.Identifiables; | ||
|
|
||
| /** | ||
| * @author Thomas Adam <tadam at silicom.fr> | ||
| */ | ||
| abstract class AbstractIdentifiableAdderAdapter<I extends IdentifiableAdder<I>> extends AbstractAdapter<I> implements IdentifiableAdder<I> { | ||
| abstract class AbstractIdentifiableAdderAdapter<T extends Identifiable<? super T>, I extends IdentifiableAdder<T, I>> extends AbstractAdapter<I> implements IdentifiableAdder<T, I> { |
There was a problem hiding this comment.
Same question as in BranchAdder
There was a problem hiding this comment.
It's again because of TieLine, which makes BranchAdder have the same kind of parameter, and as BranchAdder extends AbstractIdentifiable we need the same here.
There was a problem hiding this comment.
After the merge I needed the same for AbstractSimpleIdentifiableXml
iidm/iidm-xml-converter/src/main/java/com/powsybl/iidm/xml/AbstractTransformerXml.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
|
Kudos, SonarCloud Quality Gate passed! |
miovd
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Only partly: fixes #2227
What kind of change does this PR introduce?
Feature
What is the current behavior?
Adder interfaces do not include the add method
What is the new behavior (if this is a feature change)?
Adder interfaces include the add method
Does this PR introduce a breaking change or deprecate an API? yes
Note that it is a breaking change only for users which have added their own equipments based on the existing interfaces.