Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: BusbarSection getters in node-breaker view only return a non-null BusbarSection if it is in their voltage level #2519

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

miovd
Copy link
Contributor

@miovd miovd commented Mar 27, 2023

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
No

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix

What is the current behavior? (You can also link to an open issue here)
Busbar sections getters in node-breaker view can return a non-null busbar section if it exists even if it is not in their voltage level

What is the new behavior (if this is a feature change)?
Busbar sections getters in node-breaker view return null if the busbar section exists in another voltage level

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
No

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

…l BusbarSection if it is in their voltage level

Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.5% 87.5% Coverage
0.0% 0.0% Duplication

@miovd miovd removed the request for review from geofjamg March 27, 2023 11:18
@flo-dup flo-dup merged commit 0faa911 into main Mar 27, 2023
@flo-dup flo-dup deleted the vl_nb_bbs_getter branch March 27, 2023 11:31
miovd added a commit that referenced this pull request Mar 30, 2023
…l BusbarSection if it is in their voltage level (#2519)

* Fix: BusbarSection getters in node-breaker view only return a non-null BusbarSection if it is in their voltage level
* Add test

Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants