[Network modifications] Fix: Remove disconnectors and breakers in RemoveHvdcLine and RemoveVoltageLevel #2522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
miovd
reviewed
Mar 28, 2023
| }); | ||
|
|
||
| voltageLevel.getConnectables().forEach(Connectable::remove); | ||
| voltageLevel.getConnectables().forEach(connectable -> new RemoveFeederBayBuilder().withConnectableId(connectable.getId()).build().apply(network, throwException, computationManager, reporter)); |
There was a problem hiding this comment.
Maybe you can optimize this to only call RemoveFeederBay if it is a branch or a transformer (not useful for injection since the whole voltage level is removed in the end)
miovd
requested changes
Mar 29, 2023
Comment on lines
53
to
57
| voltageLevel.getConnectables(Branch.class).forEach(branch -> new RemoveFeederBayBuilder().withConnectableId(branch.getId()).build().apply(network, throwException, computationManager, reporter)); | ||
| voltageLevel.getConnectables(ThreeWindingsTransformer.class).forEach(threewt -> new RemoveFeederBayBuilder().withConnectableId(threewt.getId()).build().apply(network, throwException, computationManager, reporter)); | ||
| voltageLevel.getConnectables().forEach(Connectable::remove); | ||
|
|
||
| voltageLevel.remove(); |
There was a problem hiding this comment.
Hmm, I would rather do something like:
voltageLevel.getConnectables().forEach(c -> {
if (c instanceof Injection) {
c.remove();
} else {
new RemoveFeederBayBuilder()......
}
});This way, getConnectables is only called once and RemoveFeederBay called for non-Injection connectable
flo-dup
approved these changes
Mar 29, 2023
miovd
approved these changes
Mar 29, 2023
|
Kudos, SonarCloud Quality Gate passed! |
miovd
pushed a commit
that referenced
this pull request
Mar 30, 2023
…oveHvdcLine and RemoveVoltageLevel (#2522) Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restNo
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
The breakers and disconnectors are not removed.
What is the new behavior (if this is a feature change)?
In RemoveHvdcLine: the switches of the HVDC line and of the shunts are removed.
In RemoveVoltageLevel: the switches of branches in other voltage levels are removed.
the converting stations of HVDC lines on the other side are removed.