CGMES export: improve default ratedS value #2598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
marqueslanauja
changed the title
annetill
reviewed
Jun 15, 2023
| @@ -47,4 +49,9 @@ public static void write(String id, String generatorName, String equipmentContai | |||
|
|
|||
| private SynchronousMachineEq() { | |||
| } | |||
|
|
|||
| private static double defaultRatedS(double minP, double maxP, double minQ, double maxQ) { | |||
There was a problem hiding this comment.
We have asked some help at ENTSOE side. We have tried and it works. See below the code we have to do:
List<Double> values = new ArrayList<>();
values.add(Math.abs(g.getMinP()));
values.add(Math.abs(g.getMaxP()));
ReactiveLimits limits = g.getReactiveLimits();
if (limits.getKind() == ReactiveLimitsKind.MIN_MAX) {
values.add(Math.abs(g.getReactiveLimits(MinMaxReactiveLimits.class).getMinQ()));
values.add(Math.abs(g.getReactiveLimits(MinMaxReactiveLimits.class).getMaxQ()));
} else { // reactive capability curve
ReactiveCapabilityCurve curve = g.getReactiveLimits(ReactiveCapabilityCurve.class);
for (ReactiveCapabilityCurve.Point p : curve.getPoints()) {
values.add(Math.abs(p.getP()));
values.add(Math.abs(p.getMinQ()));
values.add(Math.abs(p.getMaxQ()));
}
}
values.sort(Double::compareTo);
double max = values.get(values.size() - 1);
g.setRatedS(max);
There was a problem hiding this comment.
Yes, we prepared the changes taking into account the minP, maxP, minQ, maxQ as described by ENTSO-E in the Quality of CGMES datasets and calculations v3.3 . See the relevant doc for rule SMRatedSunrealistic:
There was a problem hiding this comment.
Actually, I added two conditions in my code:
values.add(Math.sqrt(p.getP() * p.getP() + p.getMinQ() * p.getMinQ()));
values.add(Math.sqrt(p.getP()` * p.getP() + p.getMaxQ() * p.getMaxQ()));
This is to follow the rule RCCXValues4 from QoCDC.
zamarrenolm
reviewed
Jun 15, 2023
|
|
||
| private static double defaultRatedS(double minP, double maxP, double minQ, double maxQ) { | ||
| double[] array = {Math.abs(minP), Math.abs(maxP), Math.abs(minQ), Math.abs(maxQ)}; | ||
| return Arrays.stream(array).max().orElseThrow() * 10.0; |
There was a problem hiding this comment.
We do not need to apply a factor to obtain a default reasonable value
There was a problem hiding this comment.
Done. I removed factor.
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
zamarrenolm
changed the title
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
zamarrenolm
approved these changes
Jun 19, 2023
colinepiloquet
approved these changes
Jun 20, 2023
…ybl-core into cgmes_export_ratedS
annetill
approved these changes
Jun 21, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
Feature
What is the current behavior?
100 is exported as default ratedS value for synchronous machines.
What is the new behavior (if this is a feature change)?
A more precise value is calculated by using
Pmin,Pmax,QminandQmax.Does this PR introduce a breaking change or deprecate an API?
Other information: