Fix post-removal shunt compensator access #2620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David BRAQUART <david.braquart@rte-france.com>
dbraquart
force-pushed
the
issue_in_removeShuntCompensators
branch
from
f5ae92a to
5193baf
Compare
annetill
approved these changes
Jun 16, 2023
annetill
changed the title
etiennehomer
approved these changes
Jun 19, 2023
|
Kudos, SonarCloud Quality Gate passed! |
olperr1
pushed a commit
that referenced
this pull request
Jun 20, 2023
Signed-off-by: David BRAQUART <david.braquart@rte-france.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
This is a fix only visible in the persistent implementation of the iidm model, dealing with a known issue: we try to access an equipment after its deletion. This procudes an exception in powsybl-network-store (Object has been removed in current variant). Its happens in method removeShuntCompensators().
Because it is not visible in powsybl-core, there is no specific test to show this issue.
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
Other information: