Fix StateVariableExport following branch changes #2621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
annetill
reviewed
Jun 16, 2023
| network.getTwoWindingsTransformerStream().forEach(b -> writeConnectableBranchPowerFlow(cimNamespace, writer, context, b)); | ||
| network.getLineStream().forEach(b -> writeConnectableBranchPowerFlow(cimNamespace, writer, context, b)); | ||
|
|
||
| network.getDanglingLineStream(DanglingLineFilter.PAIRED).forEach(dl -> { |
There was a problem hiding this comment.
The treatment on tie lines should not be modified.
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
|
Kudos, SonarCloud Quality Gate passed! |
annetill
changed the title
annetill
approved these changes
Jun 16, 2023
zamarrenolm
approved these changes
Jun 19, 2023
olperr1
added a commit
that referenced
this pull request
Jun 20, 2023
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
During state variable export, tie lines are processed as branches and as tie lines.
What is the new behavior (if this is a feature change)?
During state variable export, tie lines are processed only one time.
Does this PR introduce a breaking change or deprecate an API?
Other information: