[CGMES] Add new parameter to make ModelDescription custom #2628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
colinepiloquet
changed the title
zamarrenolm
requested changes
Jul 3, 2023
cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/CgmesExport.java
Show resolved
Hide resolved
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
zamarrenolm
approved these changes
Jul 4, 2023
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
geofjamg
reviewed
Jul 5, 2023
...cgmes-conversion/src/test/java/com/powsybl/cgmes/conversion/test/export/CgmesExportTest.java
Outdated
Show resolved
Hide resolved
geofjamg
reviewed
Jul 5, 2023
...cgmes-conversion/src/test/java/com/powsybl/cgmes/conversion/test/export/CgmesExportTest.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
annetill
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
What is the current behavior?
Model description is the name of the file
What is the new behavior (if this is a feature change)?
Add possibility to put custom ModelDescription in CGMES files header. Thus it is possible to put a modelDescription fitting format expected in QoCDC.