Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Shortcircuit] Add new parameters #2638

Merged
merged 50 commits into from
Sep 18, 2023
Merged

[Shortcircuit] Add new parameters #2638

merged 50 commits into from
Sep 18, 2023

Conversation

colinepiloquet
Copy link
Member

@colinepiloquet colinepiloquet commented Jul 6, 2023 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

Yes #2643 + subtransientCoefficient

What kind of change does this PR introduce?

Feature

What is the current behavior?

A lot of parameters are missing
No coefficient for calculation subtransient reactance in subtransient studies

What is the new behavior (if this is a feature change)?
New parameter to calculate the subtransient reactance = subTransientCoefficient * transient reactance

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

@colinepiloquet
Add subTransientCoefficient to ShortCircuitParameters and FaultParame…
ce59859 
…ters

Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@colinepiloquet
Add test
771079b 
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@colinepiloquet
Add new parameters in ShortCircuitParameters
16a8f9a 
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@colinepiloquet
Add new parameters in FaultParameters
9fdd8c6 
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@colinepiloquet colinepiloquet changed the title [Shortcircuit] Add subTransientCoefficient parameters [Shortcircuit] Add new parameters Jul 28, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

84.6% 84.6% Coverage
0.0% 0.0% Duplication

colinepiloquet and others added 6 commits July 31, 2023 10:57
@colinepiloquet
Add tests
191ad94 
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@colinepiloquet
Add some javadoc
d2fe45d 
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@colinepiloquet
Fix version in ShortCircuitAnalysisResult
89bbf40 
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@colinepiloquet
Add initial voltage profile and coefficients in parameters
6435505 
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@colinepiloquet
Merge branch 'main' into add_subtransient_coefficient
6417e3c
@colinepiloquet
Increase test coverage
b675539 
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@colinepiloquet colinepiloquet requested a review from olperr1 August 7, 2023 11:24
colinepiloquet and others added 4 commits August 7, 2023 14:19
@colinepiloquet
change switch/case and casting
c9c3a37 
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@colinepiloquet
Some fixes
3a03eec 
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@colinepiloquet
fix
cd35a17 
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@colinepiloquet
Merge branch 'main' into add_subtransient_coefficient
3c9f6c7
olperr1 and others added 4 commits August 11, 2023 16:32
@olperr1
Merge branch 'main' into add_subtransient_coefficient
9dbcce7 
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
@colinepiloquet
Renaming
53d375c 
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@colinepiloquet
Add checks
cc5898b 
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@colinepiloquet
review
56bab08 
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@colinepiloquet
Add voltage range data file in config + add test with multiple feeders
e49a914 
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
colinepiloquet
colinepiloquet commented Sep 7, 2023
View reviewed changes
shortcircuit-api/src/main/java/com/powsybl/shortcircuit/ShortCircuitParameters.java Outdated
parameters.readExtensions(platformConfig);

return parameters;
}

private static List<VoltageRangeData> getCoefficientsFromConfig(ModuleConfig config, PlatformConfig platformConfig) {
Copy link
Member Author

@colinepiloquet colinepiloquet Sep 7, 2023 •
edited by annetill
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonenst if you could check this piece of code, it would be great

@colinepiloquet
Return empty collection instead of null
6e41236 
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@colinepiloquet
Renaming + one test
bb3c529 
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
annetill
annetill approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@annetill annetill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Coline for this work! Next step is documentation in the website.

@annetill annetill requested review from jonenst and removed request for geofjamg and rolnico September 13, 2023 09:49
geofjamg
geofjamg requested changes Sep 14, 2023
View reviewed changes
shortcircuit-api/src/main/java/com/powsybl/shortcircuit/FaultParameters.java Outdated Show resolved Hide resolved
shortcircuit-api/src/main/java/com/powsybl/shortcircuit/VoltageRangeData.java Outdated Show resolved Hide resolved
shortcircuit-api/src/main/java/com/powsybl/shortcircuit/VoltageRangeData.java Outdated Show resolved Hide resolved
shortcircuit-api/src/main/java/com/powsybl/shortcircuit/VoltageRangeData.java Outdated Show resolved Hide resolved
shortcircuit-api/src/test/resources/config.yml Outdated
with-neutral-position: true
initial-voltage-profile-mode: "CONFIGURED"
voltage-range-data: "voltage-range-data.json"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it working with an absolute path or a relative path?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the JSON file should be in the same folder as the config file. So basically this field should just have the name of the file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With CGMES boundaries, we put the files in general in a folder inside de .itools. It should work for this too, in order to create a folder but for short-circuit.

geofjamg
geofjamg reviewed Sep 14, 2023
View reviewed changes
shortcircuit-api/src/main/java/com/powsybl/shortcircuit/ShortCircuitParameters.java Outdated
parameters.readExtensions(platformConfig);

return parameters;
}

private static List<VoltageRangeData> getVoltageRangeDataFromConfig(ModuleConfig config, PlatformConfig platformConfig) {
Optional<Path> optionalVoltageRangeDataPath = config.getOptionalPathProperty("voltage-range-data");
if (optionalVoltageRangeDataPath.isPresent()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use optionalVoltageRangeDataPath.ifPresent(...) instead

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it won't work with the return value no?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

89.9% 89.9% Coverage
0.0% 0.0% Duplication

colinepiloquet and others added 3 commits September 18, 2023 10:35
@colinepiloquet
Voltage range path is now absolute
95a83d5 
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@geofjamg
Clean
9f5b94e 
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
@colinepiloquet
Merge branch 'main' into add_subtransient_coefficient
c8a60c7
@geofjamg
Clean
077cd9a 
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
@geofjamg geofjamg merged commit 99c847f into main Sep 18, 2023
5 checks passed
@geofjamg geofjamg deleted the add_subtransient_coefficient branch September 18, 2023 09:59
@colinepiloquet colinepiloquet mentioned this pull request Sep 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annetill annetill annetill approved these changes

@olperr1 olperr1 olperr1 approved these changes

@geofjamg geofjamg geofjamg approved these changes

@jonenst jonenst jonenst approved these changes

@JB-H JB-H Awaiting requested review from JB-H

Assignees
No one assigned
Labels
Breaking Change API is broken Doc needed PR: next-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@colinepiloquet @jonenst @geofjamg @olperr1 @annetill